sebwrede commented on pull request #1409: URL: https://github.com/apache/systemds/pull/1409#issuecomment-943234725
> Thank you for the comments @sebwrede :) > > I set the log level of io.netty to INFO to avoid the trace logs. I also set the maximum number of iterations to 100 and the threshold to 0.001 so that the algorithm converges. LGTM. I think this is ready to merge, but I don't know if we should wait until after the next release. What do you think, @phaniarnab? Another point: I noticed that when I run `runAll.sh` then I get the error: `Error in ./runAllMultinomial.sh on line 53` `Error in ./runAllRegression.sh on line 51` This is not related to this PR. It also happens on master. I don't know if it is something with my setup, but it does not happen with the call to `runAllFed.sh`, so that is good :smiley:. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
