mboehm7 commented on pull request #1406: URL: https://github.com/apache/systemds/pull/1406#issuecomment-955775415
LGTM - thanks for the patch. During the merge I made the following changes: * Fixed rewrite correctness (so far we checked the valid conditions on the output of the unary operator, but we need to check them on the parents of the input to ensure other consumers of the input do not read modified data; that was the reason why so many tests failed) * Disabled the rewrite by default, because lineage-based reuse needs to be adapted, and moved the flag to `OptimizerUtils` where all the other flags are. * Changed the allocation logic in the block operations to ensure correctness * Moved the tests to `functions/updateinplace`, and modified the test to have positive and negative examples. * Fixed the formatting of the test and removed unnecessary imports -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
