ywcb00 opened a new pull request #1446: URL: https://github.com/apache/systemds/pull/1446
Hi, This PR fixes two issues with the _AggregateBinaryFEDInstruction_ and the _MMFEDInstruction_. 1. It removes the seperate alignment check inside the two instructions where there is no verification that the range-aligned federated data partitions are located on the same federated worker. Since the case of having two aligned matrices is already covered by the very first if branch, I removed the whole case containing the local alignment check. 2. Since the federated spark instructions do not automatically create the output variables yet, we need to create the output matrices by an additional PUT_VAR request to the federated worker. However, this PR adds some of those PUT_VAR requests that were missing inside the _MMFEDInstruction_. In addition, this PR addresses the problem of creating an endless loop between the _acquireReadIntern()_ and the _readBlobFromHDFS()_ method (mentioned in #1390) by adding the constraint to read the file from federated even if it is broadcast but does not exist on hdfs. Thanks for review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
