j143 commented on a change in pull request #1401:
URL: https://github.com/apache/systemds/pull/1401#discussion_r756242238
##########
File path: scripts/builtin/abstain.dml
##########
@@ -1,4 +1,4 @@
-#-------------------------------------------------------------
+#
----------------------------------------------------------------------------------------------------------------------
Review comment:
We should not change this one, this will add inconsistency with license
header.
##########
File path: scripts/builtin/_genBuiltinDocs.py
##########
@@ -147,10 +147,10 @@ def parseInformation(markDownArray, fileName):
for line in markDownArray:
if INPUT:
- inputParameterCount, INPUT, INPUT_FINISHED, I_HEADER_MISSING,
commentLineCount = parseParam(inputParameters, inputParameterCount, INPUT,
INPUT_FINISHED, I_HEADER_MISSING, commentLineCount, additionalInfos, line)
+ inputParameterCount, INPUT, INPUT_FINISHED, I_HEADER_MISSING,
commentLineCount = parseParam(inputParameters, inputParameterCount, INPUT,
INPUT_FINISHED, I_HEADER_MISSING, commentLineCount, additionalInfos, line,
OUTPUT)
Review comment:
This script needs to be well tested 🥇 . For now, we can use this only 1
or 2 scripts in `scripts/staging` folder. After which, we can apply
generically. 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
