sed inplace in the release scripts is not possible because,
mvn release:prepare expects no changes in the
working directory. :(



On Thu, Dec 2, 2021 at 12:18 AM arnab phani <phaniar...@gmail.com> wrote:
>
> Sed inplace is fine for these. You can add that in the same script where
> you call mvn -Dtag.
>
> Regards,
> Arnab..
>
> On Wed, Dec 1, 2021, 19:42 Janardhan <janard...@apache.org> wrote:
>
> > Hi all,
> >
> > During the release tag creation[1], only the version in the pom.xml[2]
> > gets updated.
> >
> > mvn  -Dtag=$RELEASE_TAG release:prepare
> >
> > We got to change the version in the following places, at the tag creation
> > time
> >
> > In the src/main/python/systemds/project_info.py
> > and docs/_config.yml#L42
> >
> > A workaround for this would be to execute bash (sed -i ..) from pom.xml
> > with <execution> tag.
> >
> > Any ideas?
> >
> > --
> > [1]
> > https://github.com/apache/systemds/blob/main/dev/release/create-tag.sh#L120
> > [2]
> > https://github.com/apache/systemds/commit/6e938bdbc6071bf6919640356428f6c05fd25033
> >
> > Best Regards,
> > Janardhan
> >

Reply via email to