j143 edited a comment on pull request #1479: URL: https://github.com/apache/systemds/pull/1479#issuecomment-991065619
Hi @m2key1 @JoachimDunkel , thanks a lot for the contribution. 😸 💖 **Few house keeping comments:** 1. the jitify submodule seems to be removed. We shouldn't remove that! 2. you have kept the licenses good in all the folders except two. 3. How about adding these two functions in https://github.com/apache/systemds/blob/main/docs/site/builtins-reference.md Also, which textbook or literature is referred for the implementation? providing that would be great to review this PR better, also we could maintain it better! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
