j143 commented on pull request #1479:
URL: https://github.com/apache/systemds/pull/1479#issuecomment-992617870


   Hi @m2key1 - Just want to let you know that I am actively reviewing this PR. 
This might take 2 days (today, tomorrow).
   
   1. for 1d the operation is straight forward, I am looking at matrices etc. 
We are just row appending for unique  - I am not sure that is how we should 
handle dimensionality (matrices with different features).
   2. Strings - these are also important
   3. I will see why the spark tests are failing. Of course, you can debug 
them! :)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to