Baunsgaard commented on a change in pull request #1481:
URL: https://github.com/apache/systemds/pull/1481#discussion_r767977164
##########
File path: scripts/perftest/fed/runALSFed.sh
##########
@@ -35,24 +35,28 @@ trap 'err_report $LINENO' ERR
export SYSDS_QUIET=1
BASEPATH=$(dirname "$0")
+TEMPFILENAME=$(basename -- "$FILENAME")
+BASEFILENAME=${TEMPFILENAME%.*}
-${BASEPATH}/../genALSData.sh systemds $DATADIR; # generate the data
+${BASEPATH}/../genALS_FedData.sh systemds $DATADIR &>>
${BASEPATH}/../logs/genALS_FedData.out; # generate the data
# start the federated workers on localhost
-${BASEPATH}/utils/startFedWorkers.sh systemds $DATADIR $NUMFED "localhost";
+"date" &>> ${BASEPATH}/../logs/runAllFed.out
+${BASEPATH}/utils/startFedWorkers.sh systemds $DATADIR $NUMFED "localhost" &>>
${BASEPATH}/../logs/runAllFed.out;
Review comment:
don't append but overwrite
##########
File path: scripts/perftest/fed/runALSFed.sh
##########
@@ -35,24 +35,28 @@ trap 'err_report $LINENO' ERR
export SYSDS_QUIET=1
BASEPATH=$(dirname "$0")
+TEMPFILENAME=$(basename -- "$FILENAME")
+BASEFILENAME=${TEMPFILENAME%.*}
-${BASEPATH}/../genALSData.sh systemds $DATADIR; # generate the data
+${BASEPATH}/../genALS_FedData.sh systemds $DATADIR &>>
${BASEPATH}/../logs/genALS_FedData.out; # generate the data
# start the federated workers on localhost
-${BASEPATH}/utils/startFedWorkers.sh systemds $DATADIR $NUMFED "localhost";
+"date" &>> ${BASEPATH}/../logs/runAllFed.out
Review comment:
"date"
is equivalent to
date
##########
File path: scripts/perftest/genALS_FedData.sh
##########
@@ -0,0 +1,50 @@
+#!/bin/bash
+#-------------------------------------------------------------
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+#-------------------------------------------------------------
+
Review comment:
make same comment on location here.
##########
File path: scripts/perftest/fed/runALSFed.sh
##########
@@ -35,24 +35,28 @@ trap 'err_report $LINENO' ERR
export SYSDS_QUIET=1
BASEPATH=$(dirname "$0")
+TEMPFILENAME=$(basename -- "$FILENAME")
+BASEFILENAME=${TEMPFILENAME%.*}
-${BASEPATH}/../genALSData.sh systemds $DATADIR; # generate the data
+${BASEPATH}/../genALS_FedData.sh systemds $DATADIR &>>
${BASEPATH}/../logs/genALS_FedData.out; # generate the data
# start the federated workers on localhost
-${BASEPATH}/utils/startFedWorkers.sh systemds $DATADIR $NUMFED "localhost";
+"date" &>> ${BASEPATH}/../logs/runAllFed.out
Review comment:
don't append but overwrite
##########
File path: scripts/perftest/genBinomialData.sh
##########
@@ -19,40 +19,42 @@
# under the License.
#
#-------------------------------------------------------------
-
CMD=$1
Review comment:
same comment on location here.
##########
File path: scripts/perftest/genALSData.sh
##########
@@ -21,30 +21,31 @@
#-------------------------------------------------------------
CMD=$1
-DATADIR=$2
+DATADIR=$2/als
-FORMAT="binary" # can be csv, mm, text, binary
+FORMAT="text" # can be csv, mm, text, binary
DENSE_SP=0.9
SPARSE_SP=0.01
-BASEPATH=$(dirname $0)
+EXTRADOT=""
+if [ "${CMD}" == "systemds" ]; then EXTRADOT="." ; fi
#generate XS scenarios (80MB)
-${CMD} -f ${BASEPATH}/../datagen/genRandData4ALS.dml --nvargs
X=${DATADIR}/X10k_1k_dense rows=10000 cols=1000 rank=10 nnz=`echo "scale=0;
10000 * 1000 * $DENSE_SP" | bc` sigma=0.01 fmt=$FORMAT
-${CMD} -f ${BASEPATH}/../datagen/genRandData4ALS.dml --nvargs
X=${DATADIR}/X10k_1k_sparse rows=10000 cols=1000 rank=10 nnz=`echo "scale=0;
10000 * 1000 * $SPARSE_SP" | bc` sigma=0.01 fmt=$FORMAT
+${CMD} -f ${EXTRADOT}./datagen/genRandData4ALS.dml --nvargs
X=${DATADIR}/X10k_1k_dense rows=10000 cols=1000 rank=10 nnz=`echo "scale=0;
10000 * 1000 * $DENSE_SP" | bc` sigma=0.01 fmt=$FORMAT
Review comment:
I'm pretty sure that this change is not needed, since the script is
intended to be run one directory further in,
I would suggest that you add a comment int the top specifying where to run
it from, and even better an error that says, "wrong directory, please cd to xyz"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
