mboehm7 commented on pull request #1455: URL: https://github.com/apache/systemds/pull/1455#issuecomment-997291960
LGTM - thanks for the improvements @OlgaOvcharenko and @Baunsgaard. During the merge I made the following changes for performance / correctness: * rmEmpty rows (select all) returns shallow copy of frame block (due to copy on write semantics) * rmEmpty rows allocates the temporary object array just once outside the loops * rmEmpty cols use shallow copies of columns instead of cloned columns (due to copy on write semantics) * `DataConverter.convertVectorToIndexList` now copies a range of the physical array in order to guarantee correctness (the physical index/value arrays might be larger than the number of indexes, in which case we would have mistakenly appended column 0 one or multiple times) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
