j143 commented on a change in pull request #1489:
URL: https://github.com/apache/systemds/pull/1489#discussion_r775730328
##########
File path:
src/main/java/org/apache/sysds/runtime/matrix/data/LibCommonsMath.java
##########
@@ -76,11 +79,17 @@ else if (opcode.equals("cholesky"))
public static MatrixBlock[] multiReturnOperations(MatrixBlock in,
String opcode) {
if(opcode.equals("qr"))
return computeQR(in);
+ else if (opcode.equals("qr2"))
+ return computeQR2(in);
else if (opcode.equals("lu"))
return computeLU(in);
else if (opcode.equals("eigen"))
return computeEigen(in);
- else if ( opcode.equals("svd"))
+ else if (opcode.equals("eigen_lanczos"))
+ return computeEigenLanczos(in);
+ else if (opcode.equals("eigen_qr"))
+ return computeEigenQR(in);
+ else if (opcode.equals("svd"))
Review comment:
Hi @Baunsgaard
how about we document these functions and mention they are experimental (in
the doc)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
