Baunsgaard commented on a change in pull request #1480:
URL: https://github.com/apache/systemds/pull/1480#discussion_r776089208
##########
File path:
src/main/java/org/apache/sysds/runtime/matrix/data/LibMatrixNative.java
##########
@@ -66,18 +66,12 @@ public static boolean isMatMultMemoryBound(int m1Rlen, int
m1Clen, int m2Clen) {
* @param k number of threads
*/
public static void matrixMult(MatrixBlock m1, MatrixBlock m2,
MatrixBlock ret, int k) {
- matrixMult(m1, m2, ret, k, true);
- }
-
- public static void matrixMult(MatrixBlock m1, MatrixBlock m2,
MatrixBlock ret, int k, boolean examSparsity) {
Review comment:
FixedRet is not implemented for NativeMM, and the argument was always
set to true for all calls.
the one place the argument is used is for forcing allocation in fallback to
normal matrix multiplication, and i have changed this call to do the same as
before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
