mboehm7 commented on pull request #1517: URL: https://github.com/apache/systemds/pull/1517#issuecomment-1019558723
LGTM - thanks for the patch @Hiebl. During the merge, I only did some minor code cleanups (avoid materialization of bin positions for quantiles), and left a FIXME for us to handle NaNs correctly (currently NaNs in the input would introduce zeros into the quantile computation). @phaniarnab could you please address the NaN handling while finalizing your inputs to binning. @OlgaOvcharenko once the federated quantile is ready, could you please extend the federated transform for equi-height as well? Thanks everybody - this is a great addition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
