flo-l commented on a change in pull request #1525:
URL: https://github.com/apache/systemds/pull/1525#discussion_r793782666
##########
File path:
src/main/java/org/apache/sysds/runtime/controlprogram/paramserv/FederatedPSControlThread.java
##########
@@ -354,11 +432,12 @@ protected void computeWithBatchUpdates() {
int localStartBatchNum =
getNextLocalBatchNum(currentLocalBatchNumber++, _possibleBatchesPerLocalEpoch);
ListObject model = pullModel();
ListObject gradients =
computeGradientsForNBatches(model, 1, localStartBatchNum);
- if (_modelAvg)
+ if (_modelAvg && !_use_homomorphic_encryption)
+ // we can't call the agg fn if we use
HE, because it is implemented homomorphically in
SEALServer::aggregateCiphertexts
Review comment:
I don't think so, because this code also runs in non-encrypted mode. In
this case we need to call the agg fn.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
