BACtaki opened a new pull request #1531: URL: https://github.com/apache/systemds/pull/1531
Added `countDistinctApprox()` to Spark runtime by extending existing KMV implementation for CP. Also added `dir` parameter for `countDistinctApprox()` for both CP and Spark runtimes. Fixes [this JIRA issue](https://issues.apache.org/jira/browse/SYSTEMDS-2996?jql=project%20%3D%20SYSTEMDS%20AND%20text%20~%20%22count%20distinct%22). Coming up next in this PR 1. The type="KMV" parameter is currently being ignored. It is being validated, but ignored. 2. I tested 'countDistinctApprox()' parameters manually. It would be nice to have a parameterized builtin test for it. 3. Minor refactoring -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
