mboehm7 commented on pull request #1505: URL: https://github.com/apache/systemds/pull/1505#issuecomment-1030920218
This is a great patch (but I leave the review to @Baunsgaard as he already started) - during the merge, please rename the 'topological' to depth-first (as in the past topological sort referred to breadth-first but here it refers to our current depth-first), and potentially add the breadth-first as an enum option too (would be good to experiment with that externally). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
