mboehm7 commented on pull request #1477: URL: https://github.com/apache/systemds/pull/1477#issuecomment-1058517671
LGTM - thanks for the patch @OlgaOvcharenko, this is a great extension and very useful for plenty of pre-processing primitives. During the merge, I only made a few minor tweaks in the qpick instruction, and re-enabled the tests for column-partitioned data again (which were commented, probably for local testing). Once you get a chance, could you please then follow up and improve the performance of the histogram construction (e.g., the `GetValuesInRange` UDF) to use an array of pre-materialized bin boundaries and binary search similar to transformencode-binning? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
