BACtaki commented on pull request #1531: URL: https://github.com/apache/systemds/pull/1531#issuecomment-1059825081
> Hi @BACtaki I really like your commit, and have now merged your PR while doing some minor cleanup in the process. (tabs vs spaces, imports etc.) Thanks @Baunsgaard ! > The changes are moved to a new PR to see if the commit works in all the tests (i think they do) and once it parses it will go to main. If you still want to you can work on the processing without slicing the matrix, i think one cool design would be to extend the matrix sketch interface to do col or row aggregate directly on a matrix. instead of having the getMatrixValue() function. Agreed, aggregating on the matrix directly would be a good optimization- let me address that in a subsequent PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
