corepointer commented on PR #1566: URL: https://github.com/apache/systemds/pull/1566#issuecomment-1103821817
The rewrite was tuned down from max(rowMaxs(vec_mult())) to only rowMaxs(vect_mult()). This way the rewrite would apply more easily. The subsequent max() was fused anyway. Nevertheless, the rewrite still has issues with memory estimates when running hybrid and/or GPU exec modes. And last but not least this is an over-specialized rewrite that could be generalized into agg+vect_op. Will close with initial working implementation for Java + CUDA (leaving the mentioned issues as future work) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
