daphne-eu commented on PR #1608: URL: https://github.com/apache/systemds/pull/1608#issuecomment-1125274817
Thanks for the patch @MKehayov. As just discussed offline, this looks already good - please double check the fasterxml dependency, tabs vs spaces, exception handling, check of existing schema, use of prepared statements, and a more compact style of assertion checking in the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
