sebwrede commented on PR #1525: URL: https://github.com/apache/systemds/pull/1525#issuecomment-1144778874
I have rebased the branch on main, but since there are a lot of conflicts, it is not easy to get it right. I think there is something wrong with my merge of FederatedWorker.java, but I cannot see what is wrong. All the federated tests seem to be failing because of it. Can you see if anything looks wrong in this rebased version of FederatedWorker.java?: https://github.com/sebwrede/systemds/blob/1f8f6ed84ef3cd5c996e443005820e33bb43c1c8/src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedWorker.java Another problem is running the InOutTest. It leads to: `java.lang.UnsatisfiedLinkError: /tmp/libhe-Linux-x86_64.so6291387220729597515: libseal.so.3.7: cannot open shared object file: No such file or directory` So I understand that this is because SEAL has to be included, but I think we need to add a readme or something to define exactly how to include it, now that it is not included statically. Another problem is running the build.sh. I get the following error: `/systemds/src/main/cpp/he/libhe.cpp:23:10: fatal error: gsl/span: No such file or directory 23 | #include <gsl/span> | ^~~~~~~~~~ compilation terminated. ` So one idea could be to include a check for whether gsl/span is there in the build.sh before trying to compile and then install before the compilation. Or maybe you have some better idea for a solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
