flo-l commented on PR #1525: URL: https://github.com/apache/systemds/pull/1525#issuecomment-1144798740
One thing: in [this line](https://github.com/sebwrede/systemds/blob/1f8f6ed84ef3cd5c996e443005820e33bb43c1c8/src/main/java/org/apache/sysds/runtime/controlprogram/federated/FederatedWorker.java#L116), I think it should be `FederatedResponseEncoder`. Still, it fails locally with: ``` org.apache.sysds.runtime.DMLRuntimeException: Failed sending federated operation at org.apache.sysds.runtime.controlprogram.federated.FederatedData.executeFederatedOperation(FederatedData.java:206) at org.apache.sysds.runtime.controlprogram.federated.FederatedData.clearFederatedWorkers(FederatedData.java:236) at org.apache.sysds.api.DMLScript.cleanupHadoopExecution(DMLScript.java:548) at org.apache.sysds.api.DMLScript.execute(DMLScript.java:465) at org.apache.sysds.api.DMLScript.executeScript(DMLScript.java:304) at org.apache.sysds.api.DMLScript.main(DMLScript.java:198) Caused by: java.lang.IllegalStateException: group set already at io.netty.bootstrap.AbstractBootstrap.group(AbstractBootstrap.java:92) at org.apache.sysds.runtime.controlprogram.federated.FederatedData.executeFederatedOperation(FederatedData.java:177) ... 5 more ``` I don't know what's wrong here, but it seems unrelated to my changes. Regarding the dynamic linking: Yes, it would be nice to document this, but where? Both errors you're getting stem from SEAL not being installed on the system. In the first case the dynamic library is missing and the build error comes from the SEAL header files not being installed (SEAL bundles gsl). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
