mboehm7 commented on PR #1609: URL: https://github.com/apache/systemds/pull/1609#issuecomment-1146840484
LGTM - thanks for the patch @OlgaOvcharenko. I will merge this in with minor changes as a number of merge conflicts already accumulated. However, there is quite some redundancy in `InitFEDInstruction` - could you please (in a follow-up PR) eliminate this redundancy, construct a federatedMap, and subsequently simply call broadcastSliced as an existing primitive for transferring slices of a local data object to individual federated workers. That way, we're reuse the well-tested and compact runtime primitive without need for changing the worker handler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
