Hi! I tested Java and CUDA code generation on the connected components script on single node exec mode. That works fine. So the code generation issue that Shafaq identified seems to be contained to the map() function.
Checksums and signature seem to be fine with the rc1 artefact. A minor improvement would be to include the filename in the checksum files like so: "<checksum> <space> <filename>" on a single line without quotes. This makes checking with the appropriate utility much easier. For example: "md5sum -c systemds-3.0.0-bin.tgz.md5" would then output "OK" if the file is alright. Regards, Mark On 14.06.2022 06:35, Janardhan Pulivarthi wrote: > The voting is still open for any issues that you might have with this > RC, in your respective components of the project. > > I will cut the next release candidate today (June 14, 2022) GMT+5:30 > with the fixes. > > Regards, > Janardhan > > On Mon, Jun 13, 2022 at 9:04 PM Shafaq Siddiqi > <shafaq.sidd...@tugraz.at.invalid> wrote: >> >> -1 >> >> I am getting the following error while running the cleaning pipelines. I did >> manage to solve this by copying 'commons-compiler-3.0.16' to the lib folder. >> I have tested some of the built-ins and map() function and cleaning pipeline >> and everything seems fine except some minor validations for which I have >> generated a PR and will merge them in as soon as possible. >> >> I have tested the binary release with singlenode execution mode. >> >> Sorry for the inconvenience. >> >> Shafaq >> >> >> >> On 6/10/2022 10:14 PM, Janardhan wrote: >> >> Greetings, >> >> Voting request for the release candidate as Apache SystemDS version 3.0.0 >> >> The vote is open for at least 72 hours and passes if a majority of at >> least 3 +1 PMC votes are cast. >> >> [ ] +1 Release this package as Apache SystemDS 3.0.0 >> [ ] -1 Do not release this package because ... >> >> To learn more about Apache SystemDS, please see >> https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsystemds.apache.org%2F&data=05%7C01%7Cmdokter%40know-center.at%7C3c91343aaaa04b481cc308da4dbf5a8c%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637907781513433008%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=pD1xDdrNSaXzGkxD7GI8kUmzhvZCBrdU4krSS7EaMj8%3D&reserved=0 >> >> >> The tag to be voted on is 3.0.0-rc1 >> (06c7c40350c16b6d96eaf0c34fac07047ec92e5d): >> https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsystemds%2Ftree%2F3.0.0-rc1&data=05%7C01%7Cmdokter%40know-center.at%7C3c91343aaaa04b481cc308da4dbf5a8c%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637907781513433008%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=UiqRwSiBpbh32l%2Bm69B8%2FgyRy8Jxsy0QNZRedy7jLYo%3D&reserved=0 >> >> The release artifacts can be found at: >> https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Fsystemds%2F3.0.0-rc1%2F&data=05%7C01%7Cmdokter%40know-center.at%7C3c91343aaaa04b481cc308da4dbf5a8c%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637907781513433008%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=AbVGc7k6BFki4NgC42%2FsEmm3M1cKHr0Ylem64RM6nnc%3D&reserved=0 >> >> The maven release artifacts, including signatures, digests, etc. can >> be found at: >> https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Forgapachesystemds-1081%2Forg%2Fapache%2Fsystemds%2Fsystemds%2F3.0.0%2F&data=05%7C01%7Cmdokter%40know-center.at%7C3c91343aaaa04b481cc308da4dbf5a8c%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637907781513433008%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=bK8uCKxKi0DGGj0Gqd6FSAuDN1Rm5bS%2BGUWGS3CB8Wk%3D&reserved=0 >> >> >> >> =========================== >> == Apache Release policy == >> =========================== >> https://eur02.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.apache.org%2Flegal%2Frelease-policy.html&data=05%7C01%7Cmdokter%40know-center.at%7C3c91343aaaa04b481cc308da4dbf5a8c%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637907781513433008%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=paMOuOjgJm%2Bl%2FhWq%2BrrANiQTdAADwlHIR6XmBjRfi%2F4%3D&reserved=0 >> >> ======================================= >> == How can I help test this release? == >> ======================================= >> If you are a SystemDS user, you can help us test this release by taking an >> existing Algorithm or workload and running on this release candidate, then >> reporting any regressions. Reach out to me if you need help with testing. >> >> ================================================ >> == What justifies a -1 vote for this release? == >> ================================================ >> -1 votes should only occur for significant stop-ship bugs or legal related >> issues (e.g. wrong license, missing header files, etc). Minor bugs or >> regressions should not block this release. >> >> >> Best Regards, >> Janardhan >> release key: >> https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fs.apache.org%2Fjanardhan&data=05%7C01%7Cmdokter%40know-center.at%7C3c91343aaaa04b481cc308da4dbf5a8c%7C0d3c92e977ae4f49bd126ff29e8f1c37%7C0%7C0%7C637907781513433008%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=w63qaVYGU6xPpS4e%2FmYKXeeSy9upGwaXSGzUasM5WoY%3D&reserved=0
