MKehayov commented on code in PR #1698:
URL: https://github.com/apache/systemds/pull/1698#discussion_r981240738
##########
src/test/java/org/apache/sysds/test/functions/federated/monitoring/FederatedWorkerStatisticsTest.java:
##########
@@ -58,6 +87,54 @@ public void testWorkerStatisticsParsedCorrectly() {
Assert.assertNotEquals("Utilization stats parsed correctly", 0,
model.utilization.size());
}
+ @Test
+ public void testWorkerStatisticsPerformance() throws
InterruptedException {
Review Comment:
Only the execution definitely doesn't run for more than 50 seconds, BUT
there is a sleep function in one of the performance tests which takes 70s so
that the tool has enough time to gather 20 data entries. I left them there and
put them with ignoring which, in my opinion, is the best solution since they
don't really test any functionality but still can be used to check performance
in case there are changes on the monitoring, let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
