BACtaki opened a new pull request, #1722: URL: https://github.com/apache/systemds/pull/1722
This patch improves the validation of parameters to aliases for countDistinct() and countDistinctApprox(). The aliases have also been renamed for consistency with other builtin functions: - countDistinctRow() -> rowCountDistinct() - countDistinctCol() -> colCountDistinct() - countDistinctApproxRow() -> rowCountDistinctApprox() - countDistinctApproxCol() -> colCountDistinctApprox() countDistinctApproxRow() and countDistinctApproxCol() only accept a single additional parameter for type (default=KMV), which is optional. countDistinctRow() and countDistinctCol() have been converted from parameterized builtin functions to non-parameterized builtins as the aliases specify their respective directions implicitly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
