kykrueger commented on PR #1806: URL: https://github.com/apache/systemds/pull/1806#issuecomment-1519035420
A list of some things I'd like to adjust in either this ticket or a follow up: 1. Using ubuntu-latest could break reproducibility when new versions of ubuntu are added. I'd replace all calls to ubuntu-latest with ubuntu-22.04. 2. The applications-tests do not use setup-java and therefore use the default java installation of ubuntu-22.04, so if not replacing ubuntu-latest with a fixed version, I'd at least want to add a fixed version with setup java, but maybe even pin both a version for java and ubuntu. 3. Maybe also combine the functions, components and applications matricies into a shared matrix in order to avoid their matrix test groups from diverging, unless their matricies should remain different? I don't know enough about the project to say if this step would make sense. 4. Retention period for artifacts, the uploaded test-coverage reports may be saved for up to 400 days as artifacts. I don't think they have a ton of value to keep around that long since they can also be regenerated. I'd consider setting the retention long enough to make sure it is around at least a bit longer than it takes to get something merged, but I don't know how long this is for this project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
