kykrueger commented on PR #1821: URL: https://github.com/apache/systemds/pull/1821#issuecomment-1538842688
Looks like combining all of the test types into one matrix makes a bit of a mess of a few things. The components tests had been making use of the adopt java distribution, but the other tests had depended on openjdk and/or the R dependencies from the docker image for testing. I think it makes sense to keep things in the docker image since it allows devs to run the tests that depend on R with less worry about dependencies. Using the docker image comes with some extra complexity in the github-actions though. For example, caching the maven builds and testing against other java distributions or versions becomes more cumbersome, since these environments will require additional docker image builds. I'll make the easiest change for now that meets the requirement of merging the test-groups together, which means running them all in the docker container. A caching strategy might be worth considering though to build the image once, and share it between the testing jobs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
