Baunsgaard commented on code in PR #1848: URL: https://github.com/apache/systemds/pull/1848#discussion_r1241341602
########## src/main/python/tests/nn_nodes/__init__.py: ########## @@ -0,0 +1,20 @@ +# ------------------------------------------------------------- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +# ------------------------------------------------------------- Review Comment: Add line in end of file ########## src/main/python/tests/nn_nodes/test_affine.py: ########## @@ -0,0 +1,67 @@ +# ------------------------------------------------------------- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +# ------------------------------------------------------------- + +import unittest + +import numpy as np + +from systemds.context import SystemDSContext + +from systemds.operator.nn_nodes.affine import Affine + +dim = 6 +n = 10 +m = 5 +np.random.seed(11) +X = np.random.rand(n, dim) + +np.random.seed(10) +W = np.random.rand(dim, m) +b = np.random.rand(m) + + +class TestAffine(unittest.TestCase): + sds: SystemDSContext = None + + @classmethod + def setUpClass(cls): + cls.sds = SystemDSContext() + + @classmethod + def tearDownClass(cls): + cls.sds.close() + + def test_affine(self): Review Comment: add a dedicated tests for forward for backwards. Ideally you add multiple such tests. Then write in what you expect to get out from the operation based on a explicit input. ########## src/main/python/systemds/operator/nodes/source.py: ########## @@ -162,10 +162,18 @@ def __parse_lines_with_filter(self, path: str) -> Iterable[str]: lines = [] with open(path) as file: insideBracket = 0 + insideComment = False Review Comment: good catch ########## src/main/python/tests/nn_nodes/test_affine.py: ########## @@ -0,0 +1,67 @@ +# ------------------------------------------------------------- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +# ------------------------------------------------------------- + +import unittest + +import numpy as np + +from systemds.context import SystemDSContext + +from systemds.operator.nn_nodes.affine import Affine + +dim = 6 +n = 10 +m = 5 +np.random.seed(11) +X = np.random.rand(n, dim) + +np.random.seed(10) +W = np.random.rand(dim, m) +b = np.random.rand(m) Review Comment: I Know some of the other tests does this trick of allocating the numpy arrays up before the tests. I prefer you do not do this in this case since you want to costumize the input for each test. So please move it to individual tests. ########## src/main/python/systemds/operator/nn_nodes/relu.py: ########## @@ -0,0 +1,54 @@ +# ------------------------------------------------------------- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +# ------------------------------------------------------------- +import os.path + +from systemds.context import SystemDSContext +from systemds.operator import Matrix, Source +from systemds.utils.helpers import get_path_to_script_layers + + +class ReLU: + _sds_context: SystemDSContext + _source: Source + _X: Matrix + + def __init__(self): + self._sds_context = SystemDSContext() Review Comment: This is not allowed since it starts up a new JVM. just remove it and the variable for SDS. we can on first call extract the context from the variable X on a forward or on a Backward pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
