kykrueger commented on PR #1847:
URL: https://github.com/apache/systemds/pull/1847#issuecomment-1617683924

   @Baunsgaard thanks,
   
   Perhaps two more notes from my side in addition to benchmarking the times to 
send the data from systemds to python. We could:
   
   - [ ] add a few tips in the perftest readme about installing the python 
package for systemds since it is a new requirement
   - [ ] add tips about generating the data as a prerequisite (I had noticed it 
was needed to run the existing tests, but didn't see any suggestions to do 
this, maybe I missed something)
   
   Perhaps it would be a good follow-up task to check in the perftest shell 
scripts if the required data exists before running a test, and generating it if 
not yet present. That could also open some doors to sharing a folder and common 
naming for the test-data-sets in order to reuse the same cached data-set 
between tests.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to