Sheypex commented on PR #1850:
URL: https://github.com/apache/systemds/pull/1850#issuecomment-1629268411

   - NN classifier and regression tests are working
   - conv2d/mnist test has been found to work on java 11 but not on java 17
   - NCF has the same error on java 11 as on java 17
   - reduced number of epochs for MNIST test again, since they were still 
taking way too long, with 5 and 25 epochs they now take about 15 minutes in 
total for MAXMEM=800
   ---
   Overall summary:
   
   #### Datagen
   - added datagen scripts for NN regression and classification,
       -  only new shell script, backend uses existing .dml implementations for 
regression and classification datagen
   - for NCF, 
       - data is generated as demonstrated in 
`scripts/nn/examples/ncf-dummy-data.dml`
   - and for MNIST (conv2d)
       - added seperate script, that downloads MNIST dataset in .csv format 
from Github repo and additional scripts to trim this data down into separate 
datasets given the MAXMEM flag in `runAll.sh`
   - Generally:
       - `scripts/datagen` has respective .dml implementations 
       - `scripts/perftest/datagen` has .sh implementation parts of this datagen
   
   #### Perftests
   - added perftest scripts for NN regression and classification,
       - NN tests run on a sparse and a dense input dataset
   - for NCF,
       - NCF perftest is structurally complete and should work but is untested, 
as the .dml NCF implementation fails
   - and for MNIST (conv2d)
   - Generally:
       - These perftests adhere to the common structure of other tests: 
`scripts/perftest/scripts` houses .dml implementations that are to be tested, 
`scripts/perftest/run[xyz].sh` implement staging data and collecting timing 
data of test runs
       - tests run 2 rounds of tests with separate number of training epochs 
per given dataset
       - tests are split into a training test and a simple prediction test: the 
prediction test only runs a single prediction to check the accuracy/loss of the 
trained model
   
   #### Miscellaneous
   - `runAll.sh` now has a flag to enable the use of the GPU for NN, NCF, and 
MNIST (conv2d) tests and a flag to enable all of these
       - NN tests are currently on by default ie. flag to run them is set in 
`runAll.sh`, while the use of the GPU is disabled
   - NCF test and datagen have been disabled in `runAll.sh`, since .dml NCF 
implementation fails
   - example algorithms in `scirpts/nn/examples/README.md` have been altered to 
correctly pick and batch training data
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to