fathollahzadeh commented on PR #1865: URL: https://github.com/apache/systemds/pull/1865#issuecomment-1638352355
> Hi @fathollahzadeh > > Thanks for the isolated PR, i scrolled through it and it does not touch any files that would break existing code. I can take a closer look at another time, but given that it looks well tested i say if the automated tests pass then we merge it! > > I have one question/request, if we can avoid adding one file : src/test/scripts/functions/iogen/data/XML/sample-autolead-xml200.raw > > This is 21400 lines, can the test of xml parsing be reduced? > > Best regards Sebastian Hi @Baunsgaard Thank you for the prompt feedback and suggestions. I have made the following changes: 1. Changed the dataset directory from "data" to "in", which should resolve the license error. 2. Removed duplicate datasets 3. Reduced the XML file sizes Best, Saeed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
