Baunsgaard commented on PR #1843:
URL: https://github.com/apache/systemds/pull/1843#issuecomment-1714676884

   > > Looking at the other PR, i remembered,
   > > Please also test with uneven images with different number of row and 
column pixels.
   > 
   > I will try to incorporate this as well. Currently only the square images 
are supported, at least for rotation. if I try to rotate an image lets say 4 x 
3 by 90 degrees, then the output image has to be 3 x 4 and vice versa? And what 
if I were to rotate it by 45 degrees, I assume the dimension remains the same 
but certain part of image will be cut off.
   
   it is okay if some things are not supported, in such cases we just error out 
with a reasonable message.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to