Baunsgaard commented on code in PR #1911: URL: https://github.com/apache/systemds/pull/1911#discussion_r1330039558
########## src/test/java/org/apache/sysds/test/functions/pipelines/ImageTransformLinTransformed.csv: ########## Review Comment: if possible can we remove this file, or chose a smaller size for a test image. ########## src/test/resources/expected/ImageTransformLinInput.csv: ########## Review Comment: similar here, if we can reduce this file or remove it it would be good. ########## scripts/builtin/img_transform_linearized.dml: ########## @@ -0,0 +1,88 @@ +#------------------------------------------------------------- +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +#------------------------------------------------------------- + +# The Linearized Image Transform function applies an affine transformation to linearized images. +# Optionally resizes the image (without scaling). +# Uses nearest neighbor sampling. +# +# INPUT: +# ------------------------------------------------------------------------------------------- +# img_in Linearized input images as 2D matrix with top left corner at [1, 1] +# out_w Width of the output matrix +# out_h Height of the output matrix +# a,b,c,d,e,f The first two rows of the affine matrix in row-major order Review Comment: each variable have to have a new line in the documentation Or maybe these should be combined into the translation matrix by the caller? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
