MaximilianSchreff commented on PR #1956: URL: https://github.com/apache/systemds/pull/1956#issuecomment-1872539125
@Baunsgaard About the Queue - previously, we iterated through all variables and counted the number of cacheable objects. This was done to calculate the size of the boolean array but in a shallow manner. With the changes, we would now need to iterate through every single variable, i.e. laso recursively for lists, in order to get the size. That is why I chose a dynamic data structure. I'm not sure whether this is faster though. Since the number of live variables per function call is usually pretty low, I wasn't able to see any performance differences. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
