jessicapriebe commented on code in PR #1983:
URL: https://github.com/apache/systemds/pull/1983#discussion_r1460440699
##########
src/main/java/org/apache/sysds/runtime/matrix/data/LibCommonsMath.java:
##########
@@ -71,7 +73,7 @@ public static boolean isSupportedUnaryOperation( String
opcode ) {
}
public static boolean isSupportedMultiReturnOperation( String opcode ) {
- return ( opcode.equals("qr") || opcode.equals("lu") ||
opcode.equals("eigen") || opcode.equals("svd") );
+ return ( opcode.equals("qr") || opcode.equals("lu") ||
opcode.equals("eigen") || opcode.equals("fft") || opcode.equals("ifft") ||
opcode.equals("svd") );
Review Comment:
resolved
##########
src/main/java/org/apache/sysds/runtime/matrix/data/LibCommonsMath.java:
##########
@@ -252,6 +258,25 @@ private static EigenDecomposition
computeEigenRegularized(MatrixBlock in) {
DataConverter.convertToArray2DRowRealMatrix(in2));
}
+ private static MatrixBlock[] computeFFT(MatrixBlock in) {
+ if( in == null || in.isEmptyBlock(false) )
+ throw new DMLRuntimeException("Invalid empty block");
+
+ //run fft
Review Comment:
resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
