Baunsgaard commented on PR #1989: URL: https://github.com/apache/systemds/pull/1989#issuecomment-1911046757
Hi JayBit, While Matthias will look into details i just want to clarify, 1. None of the elements inside `org.apache.sysds.performance` are run on GitHub because they all are performance related, therefore, you do not need to comment your elements out. 2. The `org.apache.sysds.performance` package is intended to be run independently of the maven test framework, because the testing framework incurs overhead in the execution making the tests more inconsistent in performance numbers. I suggest taking a look at the README how the performance tests were intended to be run: https://github.com/apache/systemds/blob/main/src/test/java/org/apache/sysds/performance/README.md If you want to make the changes to not run though the JUnit test framework, you can take a number for your specific runs in the Main file, and hook them up to your tests: https://github.com/apache/systemds/blob/9f82e9f675c567c7f80360f3814e3a19138d7a62/src/test/java/org/apache/sysds/performance/Main.java#L104 I suggest taking something like 1000, 1001, 1002 etc. to not overlap with some other numbers. Best regards Sebastian -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
