Thanks a lot, Saeed, Mark and Sebastian for providing the fixes and inputs.
Matthias's Comments -- all addressed. > Thanks for preparing the RC. Minor questions/issues to resolve for future releases are > (1) create consistency of bin/README.md in src and bin releases (currently only in src), and Done. > (2) removing the pom.xml.releaseBackup from the src release. This file is generated during the mvn release step at which point we have no control over it. Mark's Comments -- addressed by Mark and Saeed. Sebastian's Comments -- all addressed. I have cut a new RC and shared the email. Best regards, Janardhan On Sat, 17 Feb 2024 at 07:15, Janardhan <janard...@apache.org> wrote: > Hi all > > Voting result: Candidate is not successful > > Since this release candidate did not pass our checks, let us create a new > RC with fixes for the above mentioned issues in this mail thread. > > Voting closed for this RC. If you still see any issues in any of your > runs please raise a ticket and assign the priority. > > Keep the conversation going and in mailing for the issues. (If possible, in > separate mails) > > Best Regards > Janardhan > > > On Sat, Feb 17, 2024, 06:35 Saeed Fathollahzadeh < > s.fathollahza...@gmail.com> > wrote: > > > Hi, > > That is interesting. I will take a closer look at it today or tomorrow > and > > fix it as soon as possible. > > > > Regards, > > Saeed > > > > > > *Best Regards,* > > Saeed Fathollahzadeh > > Data Management Researcher > > Database Lab of Concordia University > > 2155 Rue Guy, 10th Floor, Montreal, Canada > > https://fathollahzadeh.github.io/ > > > > > > On Fri, Feb 16, 2024 at 7:55 PM Mark Dokter <mdok...@know-center.at > > .invalid> > > wrote: > > > > > -1 > > > > > > I spotted an issue with GIO codegen. It's actually two issues. First, > > > there is one remaining stale import of commons.lang and second, the > test > > > cases (at least [1]) don't have a proper condition for success as they > > > silently report everything OK to this [2]. I fixed the actual issue > with > > > the import and filed a ticket [3] for the issue with the test cases. > > > Maybe Saeed can take a look at this. > > > > > > Regards, Mark > > > > > > > > > > > > [1] > org/apache/sysds/test/functions/iogen/MatrixGenerateReaderMMTest.java > > > > > > > > > [2] > > > org.apache.sysds.runtime.DMLRuntimeException: Failed to compile class > > > GIOReader_96515354. > > > ... > > > > > > [3] https://issues.apache.org/jira/browse/SYSTEMDS-3672 > > > > > > On 15.02.24 13:11, arnab phani wrote: > > > > -1 > > > > Thanks for preparing the RC. > > > > I could reproduce the slf4j issue (thanks to Sebastian). > > > > We need another RC with the issue fixed. > > > > > > > > Regards, > > > > Arnab.. > > > > > > > > On Wed, Feb 14, 2024 at 9:36 PM arnab phani <phaniar...@gmail.com> > > > wrote: > > > > > > > >> Thanks for the comments. > > > >> Did you get the error while using the Jar to execute any dml file? > > > >> I think we always pack the systemds jar redundantly in the lib > folder > > > for > > > >> self-containment. We will verify from the previous release's > > artifacts. > > > >> Isn't the Python API update a part of the Python release, which we > > > usually > > > >> do after the actual release in a separate process? > > > >> The SLF4J error, if a bug, is a blocker for this RC. Other comments > > > >> regarding the notice and README, I believe, are minor and can be > fixed > > > >> before release. > > > >> > > > >> Regards, > > > >> Arnab.. > > > >> > > > >> On Wed, Feb 14, 2024 at 8:47 PM Sebastian Baunsgaard <s...@bgaard.dk > > > > > >> wrote: > > > >> > > > >>> Hi Janardhan, and dev team > > > >>> > > > >>> Thanks for preparing the release. I think there are a few things > > wrong > > > in > > > >>> the release artifacts: > > > >>> > > > >>> 1. when running it always output: > > > >>> > > > >>> SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". > > > >>> SLF4J: Defaulting to no-operation (NOP) logger implementation > > > >>> SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for > > > >>> further details. > > > >>> > > > >>> Even when I specify a configuration file, this indicate that the > jar > > > >>> files included are doing something wrong. > > > >>> Am I the only one that see this behavior? If not then I think we > need > > > to > > > >>> fix it and do another release. > > > >>> > > > >>> 2. The systemds-3.2.0.jar is duplicated two places. 1. in the root, > > 2. > > > >>> inside the lib folder, I think the release should only have 1. > > > >>> > > > >>> 3. The notice says: > > > >>> Copyright [2015-2021] The Apache Software Foundation > > > >>> Instead of until this year. > > > >>> > > > >>> 4. The README indicate a spark 2 cluster and java 8, instead of the > > > >>> updated version. > > > >>> > > > >>> 5. The jar file contains more files than needed from the scripts > > > folder, > > > >>> such as aws, pipelines, utils, algorithms and datagen. > > > >>> > > > >>> 6. The release artifact did not update the python API, therefore > > there > > > is > > > >>> missing builtin functions that should be generated (tSNE). > > > >>> > > > >>> Best regards > > > >>> Sebastian > > > >>> > > > >>> On Tue, 2024-02-13 at 08:00 +0530, Janardhan wrote: > > > >>>> Greetings, > > > >>>> > > > >>>> Voting request for the release candidate as Apache SystemDS > version > > > >>> 3.2.0 > > > >>>> > > > >>>> The vote is open for at least 72 hours and passes if a majority of > > at > > > >>>> least 3 +1 PMC votes are cast. > > > >>>> > > > >>>> [ ] +1 Release this package as Apache SystemDS 3.2.0 > > > >>>> [ ] -1 Do not release this package because ... > > > >>>> > > > >>>> To learn more about Apache SystemDS, please see > > > >>>> https://systemds.apache.org/ > > > >>>> > > > >>>> > > > >>>> Release artifacts > > > >>>> --- > > > >>>> > > > >>>> The tag to be voted on is 3.2.0-rc1 > > > >>>> (fdbd240af53dffd9b72e662cf854fb4cfee172bd): > > > >>>> https://github.com/apache/systemds/releases/tag/3.2.0-rc1 > > > >>>> > > > >>>> The release artifacts can be found at: > > > >>>> https://dist.apache.org/repos/dist/dev/systemds/3.2.0-rc1/ > > > >>>> > > > >>>> The maven release artifacts, including signatures, digests, etc. > can > > > >>>> be found at: > > > >>>> > > > >>> > > > > > > https://repository.apache.org/content/repositories/orgapachesystemds-1093/org/apache/systemds/systemds/3.2.0/ > > > >>>> > > > >>>> > > > >>>> > > > >>>> Apache Release policy > > > >>>> --- > > > >>>> http://www.apache.org/legal/release-policy.html > > > >>>> > > > >>>> > > > >>>> How can I help test this release? > > > >>>> --- > > > >>>> If you are a SystemDS contributor/user, you can help us test this > > > >>> release > > > >>>> by taking an existing Algorithm or workload and running on this > > > release > > > >>>> candidate, then reporting any regressions. > > > >>>> > > > >>>> Reach out to me if you need help with testing. > > > >>>> > > > >>>> > > > >>>> What justifies a -1 vote for this release? > > > >>>> --- > > > >>>> -1 votes should only occur for significant stop-ship bugs or legal > > > >>> related > > > >>>> issues (e.g. wrong license, missing header files, etc). Minor bugs > > or > > > >>>> regressions should not block this release. > > > >>>> > > > >>>> > > > >>>> Best Regards, > > > >>>> Janardhan > > > >>>> release key: https://s.apache.org/janardhan > > > >>> > > > >>> > > > > > > > > > > > > > > > > -- > > > Dipl.-Ing. Dr.techn. Mark Dokter, BSc > > > Senior Researcher > > > > > > Know-Center GmbH > > > Research Center for Data-Driven Business & Big Data Analytics > > > Sandgasse 36, 4th floor, 8010 Graz, Austria > > > FN 199 685 f, Commercial register court: LGZ Graz > > > > > > Phone +43-316-873-30804 Mobile +43-664-88796966 > > > mdok...@know-center.at > > > > > > > AILEVATOR: Accelerating AI projects to the highest level: > > > www.know-center.at/ailevator > > > > > >
