Nakroma commented on PR #2025: URL: https://github.com/apache/systemds/pull/2025#issuecomment-2176521279
Hey @Baunsgaard I actually completely forgot the backwards pass - sorry about that, it is added now! About the multi returns - I wasn't 100% sure if returns for forward/backward passes are standardized. So I assumed here how it's handled in affine.py and relu.py is the standard - i.e. I check for a MultiReturn or a single node and return based on that. This might have to be changed depending on how the layer generator will work in the future though. Let me know if you think there is a better solution for that also. Best, Tarek -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
