mboehm7 commented on code in PR #2049:
URL: https://github.com/apache/systemds/pull/2049#discussion_r1676963439
##########
src/main/java/org/apache/sysds/runtime/data/SparseBlockCOO.java:
##########
@@ -319,8 +319,8 @@ public long size(int rl, int ru, int cl, int cu) {
for(int i=rl; i<ru; i++)
if( !isEmpty(i) ) {
int start = internPosFIndexGTE(i, cl);
- int end = internPosFIndexGTE(i, cu);
- nnz += (start!=-1) ? (end-start) : 0;
+ int end = internPosFIndexLTE(i, cu-1);
Review Comment:
I just don't trust example test cases if there is no good explanation for
why this is necessary (and conceptually this change is wrong). I'll try to
revert this to get all new test cases working (there must be something else
being wrong if they're failing) - which test failed with the old code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
