Baunsgaard commented on PR #2046: URL: https://github.com/apache/systemds/pull/2046#issuecomment-2258170736
Hi @R4nne , Thanks for the PR. The code unfortunately does not fit well, and the script placed in the root folder does not contribute to the system overall. Furthermore, the hard-coded paths make it impractical for reproducibility. If you would like to contribute I would suggest that you move your script to 'scripts/perftest/python/...' and improve on the comparison such that I would also understand what is going on. Additionally could you please translate your comments to English since the system and community use English for communication? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
