cs-ally commented on code in PR #2032:
URL: https://github.com/apache/systemds/pull/2032#discussion_r1700306926


##########
src/main/java/org/apache/sysds/runtime/util/Py4jConverterUtils.java:
##########
@@ -114,6 +120,82 @@ public static MatrixBlock convertPy4JArrayToMB(byte[] 
data, int rlen, int clen,
                return mb;
        }
 
+       public static Array<?> convert(byte[] data, int numElements, 
Types.ValueType valueType) {

Review Comment:
   I wasn’t able to find existing tests for the Py4jConverterUtils class. Could 
you please advise where I should add new tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to