mboehm7 commented on PR #2067: URL: https://github.com/apache/systemds/pull/2067#issuecomment-2302636015
LGTM - thanks for the patch and the tests @lachezar-n. During the merge I fixed the missing license headers, the incorrect formatting (tabs over spaces in Java code), and a few warnings. Initially, the tests `loadInstanceTableTest` and `loadCSVFileAWSTest` were failing for me (concurrent file access in Windows I/O) but after fixing the warnings (one of which was a file resource leak), these tests passed then as well. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
