mboehm7 commented on PR #2071: URL: https://github.com/apache/systemds/pull/2071#issuecomment-2308352876
Thanks @OlgaOvcharenko for getting started on this new optimizer. I would recommend to return L and R as well from the update function (similar to we do it in Adam), add the init function (can be zero initialized), and maybe add the reference to the function documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
