Baunsgaard commented on PR #2066:
URL: https://github.com/apache/systemds/pull/2066#issuecomment-2314686542
The changes improves the general performance of the binary operations.
The biggest difference is a 100x improvement in sparse-sparse operations
with sparse output, (such as plus of two matrix blocks of 0.1 sparsity)
Performance numbers are with 10k x 10k matrix blocks:
There is one regression in sparse sparse Matrix Matrix for Multiply, after
more detailed experiments it seems to be related to how the experiment was
measured, making the run of multiply much faster if run after the very slow
plus implementation.
```txt
After (Laptop):
Sparse Sparse 0.1 plus, 98.832+- 7.141 ms,
mult, 44.119+- 2.745 ms,
Dense Sparse 0.1 plus, 194.137+- 12.295 ms,
mult, 64.769+- 4.821 ms,
Sparse Dense 0.1 plus, 183.248+- 11.647 ms,
mult, 55.820+- 6.887 ms,
Dense Dense plus, 143.174+- 12.294 ms,
mult, 149.676+- 10.531 ms,
Before (Laptop):
Sparse Sparse 0.1 plus, 1447.166+- 61.974 ms,
mult, 42.406+- 3.586 ms,
Dense Sparse 0.1 plus, 187.316+- 10.535 ms,
mult, 63.575+- 4.388 ms,
Sparse Dense 0.1 plus, 205.104+- 8.837 ms,
mult, 63.312+- 3.629 ms,
Dense Dense plus, 158.681+- 15.273 ms,
mult, 158.430+- 11.415 ms,
After Su1 Server:
Sparse Sparse 0.1 plus, 17.588+- 5.841 ms,
mult, 8.329+- 0.681 ms,
Dense Sparse 0.1 plus, 124.346+- 15.329 ms,
mult, 9.946+- 0.951 ms,
Sparse Dense 0.1 plus, 121.487+- 14.905 ms,
mult, 9.839+- 0.929 ms,
Dense Dense plus, 117.969+- 14.837 ms,
mult, 117.562+- 14.651 ms,
Before Su1 Server:
Sparse Sparse 0.1 plus, 1207.587+-150.732 ms,
mult, 3.937+- 1.495 ms,
Dense Sparse 0.1 plus, 141.851+- 27.322 ms,
mult, 11.130+- 1.449 ms,
Sparse Dense 0.1 plus, 137.890+- 27.335 ms,
mult, 10.928+- 1.217 ms,
Dense Dense plus, 137.137+- 27.108 ms,
mult, 136.903+- 27.057 ms,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
