Baunsgaard opened a new pull request, #2101:
URL: https://github.com/apache/systemds/pull/2101
I discovered something concerning,
the default compareMatrices function in TestUtils use a flag to compare cell
values, called ignoreNaN.
When this flag is enabled we compare cells with:
```java
if( ignoreNaN && (v1.isNaN() || v1.isInfinite() || v2.isNaN() ||
v2.isInfinite()) )
return true;
```
This means that all tests using cellCompare, ignore comparing if any side
contains a infinite or NaN.
This flag unfortunately invalidate the result of many tests and therefore i
open this PR to validate which tests are affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
