Baunsgaard commented on PR #2103: URL: https://github.com/apache/systemds/pull/2103#issuecomment-2352435362
LGTM the implementation looks solid. However, we are missing code coverage in the test. The python test is great to ensure that we give the same results as numpy, however out code coverage only include internal java tests. I would suggest to add a component test that just covers the call to LibMatrixReorg, where you test sparse inputs and dense inputs. It can be inspired by: src/test/java/org/apache/sysds/test/component/matrix/binary/BinaryOpTest.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
