e-strauss commented on code in PR #2113:
URL: https://github.com/apache/systemds/pull/2113#discussion_r1772303335
##########
src/main/python/systemds/script_building/dag.py:
##########
@@ -43,6 +43,8 @@ class OutputType(Enum):
NONE = auto()
SCALAR = auto()
STRING = auto()
+ INT = auto()
+ BOOLEAN = auto()
Review Comment:
But isnt STRING also a value type of Scalar?
I added boolean and int there since in the scalar class, the value type of
the scalar is determined by this. But you're right it would make more sense to
put the value type in a different enum and create a new attribute, so that
there is one field for the data type (matrix, frame, scalar) and one for the
value types (double, integer, string, boolean)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
