Baunsgaard commented on code in PR #2119:
URL: https://github.com/apache/systemds/pull/2119#discussion_r1775280192
##########
src/main/python/systemds/operator/operation_node.py:
##########
@@ -174,11 +172,15 @@ def write(self, destination: str, format: str = "binary",
**kwargs: Dict[str, VA
unnamed_inputs = [self, f'"{destination}"']
named_parameters = {"format": f'"{format}"'}
named_parameters.update(kwargs)
- return OperationNode(self.sds_context, 'write', unnamed_inputs,
named_parameters, output_type=OutputType.NONE)
+ return OperationNode(self.sds_context, 'write', unnamed_inputs,
named_parameters)
def print(self, **kwargs: Dict[str, VALID_INPUT_TYPES]) -> 'OperationNode':
""" Prints the given Operation Node.
There is no return on calling.
To get the returned string look at the stdout of SystemDSContext.
"""
- return OperationNode(self.sds_context, 'print', [self], kwargs,
output_type=OutputType.NONE)
+ return OperationNode(self.sds_context, 'print', [self], kwargs)
+
+ def data_type(self):
+ return "operation_node"
+
Review Comment:
if we can remove it, lets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
