e-strauss commented on code in PR #2149:
URL: https://github.com/apache/systemds/pull/2149#discussion_r1866822653
##########
src/main/java/org/apache/sysds/runtime/compress/colgroup/ColGroupSDCZeros.java:
##########
@@ -848,23 +848,52 @@ else if(points[c].o < of)
while(c < points.length && points[c].o < last)
c++;
- c = processRow(points, sr, nCol, c, of,
_data.getIndex(it.getDataIndex()));
+ c = processRowSparse(points, sr, nCol, c, of,
_data.getIndex(it.getDataIndex()));
}
@Override
protected void denseSelection(MatrixBlock selection, P[] points,
MatrixBlock ret, int rl, int ru) {
- throw new NotImplementedException();
+ final DenseBlock dr = ret.getDenseBlock();
Review Comment:
oh yeah, comes from the + signs, the first block I edited in the IDE and +
sign confused the IDE to make these wild indentations. After that I edited the
block in a separate editor first^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
