min-guk commented on PR #2147:
URL: https://github.com/apache/systemds/pull/2147#issuecomment-2556931785

   #### Updates
   1. Modified the selection process for child FedPlan to choose the plan with 
the minimum cost among those with the same fedOutType.
   2. Added functionality to output the DAG of the optimal FedPlan.
   3. Developed an integrated test code that combines the Memo Table, Cost 
Estimator, and Cost Enumerator instead of focusing on specific components.
   
   #### Unchanged Features
   1. The FedPlan and FedVariant classes are retained to avoid redundant cost 
calculations.
   2. The Cost Enumerator already supports multiple child FedPlans (two or 
more), and no modifications were made.
   
   #### Discussion Points
   1. In the current test code, the _outputMemEstimate is initialized to -1, 
leading to incorrect memory access and network cost calculations, which produce 
an invalid FedPlan. This needs to be fixed.
   2. If necessary, we may need to verify that all operations in the federated 
plans correctly set _outputMemEstimate or update the Cost Estimator to account 
for such exceptional cases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@systemds.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to